Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep side buffers on vsplit #145

Merged
merged 13 commits into from
Jan 19, 2023
Merged

Conversation

shortcuts
Copy link
Owner

@shortcuts shortcuts commented Jan 16, 2023

📃 Summary

supersede #113
closes #110

This PR aims at keeping the side buffers open while entering in vsplit. The goal is to be able to make the side buffer resizes until there's no space left so we can close them, and re-create them along the way.

It seems to remove most complexity of guessing splits, which is great.

  • resize side buffers until there's no more space left
  • nvim default behaviors of split/vsplit is kept intact
  • vsplit tests
  • split tests
  • vsplit + split tests
  • cleanup code
  • leverage init instead of resize

📸 Preview

before after
Screenshot 2023-01-19 at 21 43 43 Screenshot 2023-01-19 at 21 42 28
Screenshot 2023-01-19 at 21 45 46 Screenshot 2023-01-19 at 21 45 29

@shortcuts shortcuts self-assigned this Jan 16, 2023
@shortcuts shortcuts merged commit 0029fee into main Jan 19, 2023
@shortcuts shortcuts deleted the feat/keep-side-buffers-vsplit branch January 19, 2023 22:41
shortcuts pushed a commit that referenced this pull request Jan 29, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2023-01-29)


### Features

* handle multiple tabs
([#154](#154))
([3f0efca](3f0efca))
* keep side buffers on vsplit
([#145](#145))
([0029fee](0029fee))
* keeps side buffers for current tab
([#150](#150))
([e513dc3](e513dc3))


### Bug Fixes

* cleanup after tab feature
([#158](#158))
([5fe00a0](5fe00a0))
* right color group never deleted
([#153](#153))
([fce7bcb](fce7bcb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: do not kill side buffers in vsplit, if there's enough space
1 participant