xds: avoid unnecessary dns lookup

shivaspeaks · Mar 2, 2025 · 6bccd0a · 6bccd0a
1 parent cdab410
commit 6bccd0a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/xds/src/main/java/io/grpc/xds/EnvoyServerProtoData.java b/xds/src/main/java/io/grpc/xds/EnvoyServerProtoData.java
@@ -21,13 +21,13 @@
 import com.google.auto.value.AutoValue;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.collect.ImmutableList;
+import com.google.common.net.InetAddresses;
 import com.google.protobuf.util.Durations;
 import io.envoyproxy.envoy.extensions.transport_sockets.tls.v3.CommonTlsContext;
 import io.grpc.Internal;
 import io.grpc.xds.client.EnvoyProtoData;
 import io.grpc.xds.internal.security.SslContextProviderSupplier;
 import java.net.InetAddress;
-import java.net.UnknownHostException;
 import java.util.Objects;
 import javax.annotation.Nullable;
 
@@ -150,9 +150,9 @@ abstract static class CidrRange {
 
     abstract int prefixLen();
 
-    static CidrRange create(String addressPrefix, int prefixLen) throws UnknownHostException {
+    static CidrRange create(String addressPrefix, int prefixLen) throws IllegalArgumentException {
       return new AutoValue_EnvoyServerProtoData_CidrRange(
-          InetAddress.getByName(addressPrefix), prefixLen);
+          InetAddresses.forString(addressPrefix), prefixLen);
     }
   }
 

diff --git a/xds/src/main/java/io/grpc/xds/XdsListenerResource.java b/xds/src/main/java/io/grpc/xds/XdsListenerResource.java
@@ -43,7 +43,6 @@
 import io.grpc.xds.Filter.FilterConfig;
 import io.grpc.xds.XdsListenerResource.LdsUpdate;
 import io.grpc.xds.client.XdsResourceType;
-import java.net.UnknownHostException;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashSet;
@@ -453,7 +452,7 @@ private static FilterChainMatch parseFilterChainMatch(
         sourcePrefixRanges.add(
             CidrRange.create(range.getAddressPrefix(), range.getPrefixLen().getValue()));
       }
-    } catch (UnknownHostException e) {
+    } catch (IllegalArgumentException e) {
       throw new ResourceInvalidException("Failed to create CidrRange", e);
     }
     ConnectionSourceType sourceType;