Remove scaffold code from operator-sdk init #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
release-note-none
qu1queee
force-pushed
the
remove_sdk_deps_01
branch
from
161b032 to
1d9e7dd
Compare
SaschaSchwarze0
approved these changes
Feb 22, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
qu1queee
force-pushed
the
remove_sdk_deps_01
branch
2 times, most recently
from
b71075e to
b717056
Compare
This code was generated as part of the scaffold when using the sdk. This code was intended to mitigate a user error observed when using "operator-sdk up local" cmd. See operator-framework/operator-sdk#2190 for more information. We do not longer need this code. The metrics endpoint for prometheus is initialized by controller-runtime in the background. Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
qu1queee
force-pushed
the
remove_sdk_deps_01
branch
from
b717056 to
cc74f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This code was generated as part of the scaffold when using the sdk. This code was intended to mitigate a user error observed when using "operator-sdk up local" cmd.
See operator-framework/operator-sdk#2190 for more information.
We do not longer need this code. The metrics endpoint for prometheus is initialized by controller-runtime in the background.
This addresses part of #584
Submitter Checklist
Release Notes