Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hosts #240

Merged
merged 1 commit into from
Aug 17, 2020
Merged

fix hosts #240

merged 1 commit into from
Aug 17, 2020

Conversation

wzv5
Copy link
Contributor

@wzv5 wzv5 commented Aug 10, 2020

When hosts exist but query type do not match, an empty result should be returned.

When hosts exist but query type do not match, an empty result should be returned.
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   49.84%   49.84%           
=======================================
  Files          13       13           
  Lines         660      660           
=======================================
  Hits          329      329           
  Misses        283      283           
  Partials       48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c127b...8b05e38. Read the comment docs.

@shawn1m
Copy link
Owner

shawn1m commented Aug 15, 2020

I think your method might be one of the hosts matching strategies so providing an option is preferred for the needs of various users.

@wzv5
Copy link
Contributor Author

wzv5 commented Aug 15, 2020

But as you can see, all systems behave like this. I don't think it needs an option.

@shawn1m
Copy link
Owner

shawn1m commented Aug 15, 2020

I don't have IPv6 testing environment for now and I will appreciate it that you could find an example and verify it for me if possible.
Thanks a lot!

@wzv5
Copy link
Contributor Author

wzv5 commented Aug 17, 2020

@shawn1m
Copy link
Owner

shawn1m commented Aug 17, 2020

Understood. Making overture work like coredns is acceptable.
Merged. Thanks!

@shawn1m shawn1m merged commit 29cd667 into shawn1m:master Aug 17, 2020
@wzv5 wzv5 deleted the fix-hosts branch August 17, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants