-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WebVTT): Handle badly formed VTT #6147
feat(WebVTT): Handle badly formed VTT #6147
Conversation
@gkatsev can your review it also? Thanks! |
Yes, taking a look. Decided it was worth taking a look at the spec, and it seems like I've also confirmed the behavior in firefox, chrome, and safari, where if there's For example:
will only render and
will only render and
will render as Given this, we can probably even simplify the escape a bit. |
I will remove the function I added to string utils and create a method in VTT parser just for this. |
Handle remove chevrons that appear as part of the inner text of the element to avoid parse failure.