(fix) Subtitles are shown stacked #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Feb 10, 2021
|
All tests passed! |
shaka-bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
In issue #3151, some TVs showed subtitles stacked on one another when one should have expired. This only occurred on some platforms because it required very specific values for video.currentTime at the exact moment the UI text displayer calculated visibility. Limited precision on video.currentTime on some platforms may have exposed the edge case, but it was always possible. PR #3152 fixed the issue by correcting the visibility calculation. Cue end times should be excluded from their visibility range, i.e. (start, end]. This adds a new regression test for this edge case using our screenshot-based layout tests. Note that the behavior can only be controlled when we control text display through the UI. When using native text display from the browser, the exact visibility and interpretation of timing is entirely up to the browser. As of Feb 2021, Chrome, Edge, and Safari all do it wrong, and Firefox does it right. Change-Id: I2cdb8a2a759960d5ed8ce8790bf9daaeb2a335eb
|
JFYI, Chrome, Edge, and Safari all get this wrong in their native cue rendering. FF & IE/legacy Edge get it right. I filed these issues with the browser vendors to make the same/similar fix in the browser for native cue display:
|
joeyparrish
pushed a commit
that referenced
this pull request
Feb 25, 2021
We've seen some SmartTVs show one subtitle without removing the previous one. I think this is happening because two different subtitles may meet the condition of "greater or equal than" and "lower or equal than" at the same time. After changing the greater than or equal with a greater than subtitles were fixed. @joeyparrish will add a regression test after this fix. Closes #3151
joeyparrish
added a commit
that referenced
this pull request
Feb 25, 2021
In issue #3151, some TVs showed subtitles stacked on one another when one should have expired. This only occurred on some platforms because it required very specific values for video.currentTime at the exact moment the UI text displayer calculated visibility. Limited precision on video.currentTime on some platforms may have exposed the edge case, but it was always possible. PR #3152 fixed the issue by correcting the visibility calculation. Cue end times should be excluded from their visibility range, i.e. (start, end]. This adds a new regression test for this edge case using our screenshot-based layout tests. Note that the behavior can only be controlled when we control text display through the UI. When using native text display from the browser, the exact visibility and interpretation of timing is entirely up to the browser. As of Feb 2021, Chrome, Edge, and Safari all do it wrong, and Firefox does it right. Backported to v3.0.x Change-Id: I2cdb8a2a759960d5ed8ce8790bf9daaeb2a335eb
joeyparrish
pushed a commit
that referenced
this pull request
Mar 10, 2021
We've seen some SmartTVs show one subtitle without removing the previous one. I think this is happening because two different subtitles may meet the condition of "greater or equal than" and "lower or equal than" at the same time. After changing the greater than or equal with a greater than subtitles were fixed. @joeyparrish will add a regression test after this fix. Closes #3151
This was referenced Mar 16, 2021
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #3151.
We've seen some SmartTVs show one subtitle without removing the previous one.
I think this is happening because two different subtitles may meet the condition of "greater or equal than" and "lower or equal than" at the same time. After changing the greater than or equal with a greater than subtitles were fixed.