Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DASHEventMessageBox Version 1 #3147

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Support for DASHEventMessageBox Version 1 #3147

merged 1 commit into from
Feb 9, 2021

Conversation

duggaraju
Copy link
Contributor

Adds support to parse version 1 of 'emsg' boxes.
The structure of 'emsg' box is described in the DASH-IF spec at
https://dashif-documents.azurewebsites.net/Events/master/event.html#emsg-format
Added unit test to ensure the box is correctly parsed.

Adds support to parse v1 of 'emsg' boxes.
The structure of emsg box is described in the DASH-IF specs at
https://dashif-documents.azurewebsites.net/Events/master/event.html#emsg-format
Added unit test to ensure the box is corectly parsed.
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit b891d27 into shaka-project:master Feb 9, 2021
joeyparrish pushed a commit that referenced this pull request Feb 25, 2021
Adds support to parse v1 of 'emsg' boxes.

The structure of emsg box is described in the DASH-IF specs at
https://dashif-documents.azurewebsites.net/Events/master/event.html#emsg-format

Closes #1539
@duggaraju duggaraju deleted the emsg_v1 branch March 9, 2021 18:31
joeyparrish pushed a commit that referenced this pull request Mar 10, 2021
Adds support to parse v1 of 'emsg' boxes.

The structure of emsg box is described in the DASH-IF specs at
https://dashif-documents.azurewebsites.net/Events/master/event.html#emsg-format

Closes #1539

Backported to v2.5.x

Change-Id: I6f5e5dd7c90487eafb7d050f9f8d1a5488dcfd78
joeyparrish added a commit that referenced this pull request Mar 15, 2021
This reverts commit ff9a344.

Issue #1539 will not be fixed in v2.5.x after all, because of the
difficulty of backporting the second PR (#3198), which is needed for
the correct functioning of v1 emsg box support.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants