Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move drmEngine_.attach() from onLoad_ to onInitializeDrm_ #3109

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 20, 2021

Closes: #2915

@avelad
Copy link
Member Author

avelad commented Jan 20, 2021

@joeyparrish can you review it?

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit c31fc47 into shaka-project:master Jan 20, 2021
@avelad avelad deleted the attach-drmengine branch January 20, 2021 20:59
joeyparrish pushed a commit that referenced this pull request Jan 25, 2021
joeyparrish pushed a commit that referenced this pull request Feb 4, 2021
Closes: #2915

Backported to v2.5.x

Change-Id: Ib333e7e5f8becffb3bedfe599b168bc79be2eb90
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webkitGenerateKeyRequest polyfill exception ( at least from WebOS 3.0 )
3 participants