-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-standard DASH PlayReady UUID #2474
Merged
joeyparrish
merged 2 commits into
shaka-project:master
from
avelad:non-standard-playready-uuid
Apr 1, 2020
Merged
Add non-standard DASH PlayReady UUID #2474
joeyparrish
merged 2 commits into
shaka-project:master
from
avelad:non-standard-playready-uuid
Apr 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Mar 30, 2020
Test Failure:
|
I’ll review it, sorry about that |
No worries. Probably just one small test update is needed. |
@joeyparrish I fixed the test! |
joeyparrish
approved these changes
Mar 30, 2020
All tests passed! |
@joeyparrish , Is there something else I can do or can you already merge it? |
No, it's okay to merge. I just missed the email from the build bot. Thanks for the reminder. |
joeyparrish
pushed a commit
that referenced
this pull request
Apr 10, 2020
Resolves #2440 Backported to v2.5.x Change-Id: I02e6c55a75ba3cbb3c37c1b83279fe4214c6065a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2440