Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower case codec string for IMSC1 Text profile #2381

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

porcelijn
Copy link
Contributor

Fixes #2378

  • register TTML handler for stpp.ttml.im1t codec
  • adjusted HLS test case to comply with rfc8216bis section 4.4.5.2
    This change keeps the legacy support for codec string stpp.TTML.im1t. Note that while unit tests pass without this, there is good reason to assume that there is still plenty content out there using the legacy content string.

To test:

 - register TTML handler for `stpp.ttml.im1t` codec
 - adjusted HLS test case to comply with rfc8216bis section 4.4.5.2
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@porcelijn
Copy link
Contributor Author

@googlebot Yup, I signed it

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@porcelijn porcelijn changed the title Add lower case codec string for IMSC1 Text profile (#2378) Add lower case codec string for IMSC1 Text profile Feb 6, 2020
@ismena
Copy link
Contributor

ismena commented Feb 6, 2020

@porcelijn LGTM, let me run your PR through our build bot

@shaka-bot
Copy link
Collaborator

All tests passed!

@ismena ismena merged commit 5025f2c into shaka-project:master Feb 6, 2020
@ismena
Copy link
Contributor

ismena commented Feb 6, 2020

Looking good, thanks for the PR!

joeyparrish pushed a commit that referenced this pull request Mar 11, 2020
Backported to v2.5.x

Closes #2378

Change-Id: Ic06dca3fecfb6174ddfccb8bcfbbdfb6cc43d680
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codec string for IMSC1 Text should have ...ttml... (lower case)
4 participants