Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable video when the media element is AUDIO #2371

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Disable video when the media element is AUDIO #2371

merged 4 commits into from
Feb 6, 2020

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 3, 2020

Resolves #2246

@ismena ismena requested a review from joeyparrish February 3, 2020 18:25
@ismena
Copy link
Contributor

ismena commented Feb 3, 2020

@joeyparrish I'm not too familiar with the load graph logic. Could you please review?

theodab
theodab requested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that this is the correct place to put this code.

@avelad avelad requested a review from theodab February 5, 2020 21:36
theodab
theodab requested changes Feb 5, 2020
View reviewed changes
@shaka-bot
Copy link
Collaborator

All tests passed!

@avelad avelad requested a review from theodab February 6, 2020 07:14
@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit d551a15 into shaka-project:master Feb 6, 2020
@theodab
Copy link
Contributor

theodab commented Feb 6, 2020

Thanks for all of your PRs!

@avelad avelad deleted the disablevideo-audioelement branch February 7, 2020 10:11
joeyparrish pushed a commit that referenced this pull request Mar 11, 2020
@joeyparrish
Disable video when the media element is AUDIO (#2371)
551d2d7 
Closes #2246

Backported to v2.5.x

Change-Id: Ia32d46409f7b90ec5b7494c1682c79a5c969bc55
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't read video segments if the player is attached to an <audio> element.
4 participants
@avelad @ismena @shaka-bot @theodab