feature: Offline PSSH support for manifest that are missing inline init data

[avelad]

This is a PR for the same thing as #2042 for solving issue #1531 . I took the comments from #2042 and created a solution based on that with the issues resolved.

I test different type of contents and all works. However I know that the bot doesn't test on machine with persistent support, please review it manually also.

[avelad]

Note: I tested all in Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36

[joeyparrish]

Thank you so much for working on this!

[avelad]

@joeyparrish I reviewed all comments

[joeyparrish]

Looks good otherwise. Thanks!

[avelad]

I have updated the PR with the necessary changes.

[avelad]

I have updated the PR with the necessary changes

[avelad]

@joeyparrish , can you review it again with the latest changes?

[joeyparrish]

@avelad, sorry for the delay. I'm re-reviewing now.

[shaka-bot]

Test Failure:

Chrome 77.0.3865 (Linux 0.0.0)
  Offline stores, plays, and deletes protected content with a temporary license FAILED
    TypeError: Cannot read property 'length' of null
        at <Jasmine>
        at lib/offline/storage.js:520:29 <- lib/offline/storage.js:9465:48
        at <Jasmine>
        at lib/offline/storage.js:519:33 <- lib/offline/storage.js:9462:45
        at <Jasmine>
        at lib/offline/storage.js:518:30 <- lib/offline/storage.js:9458:42
        at <Jasmine>
        at _class._callee4$ (lib/offline/storage.js:517:47 <- lib/offline/storage.js:9454:78)
        at tryCatch (node_modules/babel-polyfill/dist/polyfill.js:6900:40)
        at Generator.invoke [as _invoke] (node_modules/babel-polyfill/dist/polyfill.js:7138:22)
        at Generator.prototype.<computed> [as next] (node_modules/babel-polyfill/dist/polyfill.js:6952:21)

Failed 1 tests, passed 1698, skipped 7

[avelad]

I'm going to check the error, and tomorrow I'll fix it

[joeyparrish]

Thanks!

[avelad]

@joeyparrish, I already corrected, there was a missing comprobation. It's weird because on my mac it didn't fail

[shaka-bot]

All tests passed!

[avelad]

Now that all the shaka-bot tests have passed, is it possible/safe to merge it?

[joeyparrish]

Generally, yes. But in this case, I'm doing an additional test pass in our lab, so that we can check this against all supported platforms. I should have results within the hour.

[joeyparrish]

All tests passed in our lab. Thanks for your patience!