Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm update fails with npm v5 #854

Closed
joeyparrish opened this issue Jun 6, 2017 · 0 comments
Closed

npm update fails with npm v5 #854

joeyparrish opened this issue Jun 6, 2017 · 0 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

While debugging #776, I updated to npm v5. In this version, at least on Windows, "npm update" seems to have no effect on a clean install. This causes build/all.py to fail.

"npm update" also does not update packages when required versions in package.json change.

As far as I can tell, "npm update" semantics have changed, and we should always be using "npm install".
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jun 6, 2017
@joeyparrish joeyparrish self-assigned this Jun 6, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jun 6, 2017
shaka-bot pushed a commit that referenced this issue Jun 6, 2017
@joeyparrish
Fix pollution from npm on Windows and fix npm v5
b3f29a3 
Closes #776, #854

Change-Id: I63e785342e051042ba603b63973ddfdc89d80f1a
joeyparrish added a commit that referenced this issue Jun 15, 2017
@joeyparrish
Fix pollution from npm on Windows and fix npm v5
facbcbb 
Closes #776, #854

Change-Id: I63e785342e051042ba603b63973ddfdc89d80f1a
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot