Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to more easily set single config fields #763

Closed
joeyparrish opened this issue Apr 26, 2017 · 1 comment
Closed

Allow users to more easily set single config fields #763

joeyparrish opened this issue Apr 26, 2017 · 1 comment
Assignees
@ismena
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.4

Comments

@joeyparrish
Copy link
Member

Instead of this:

player.configure({ manifest: { retryParameters: { maxAttempts: 1 }}});

It would be easier to write (and read) this:

player.configure('manifest.retryParameters.maxAttempts', 1);

Perhaps we could allow both styles by detecting the number or types of arguments.
@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 26, 2017
@joeyparrish joeyparrish added this to the Backlog milestone Apr 26, 2017
@ismena ismena self-assigned this Sep 11, 2017
@joeyparrish joeyparrish modified the milestones: Backlog, v2.4 May 9, 2018
joeyparrish pushed a commit that referenced this issue May 9, 2018
@ismena @joeyparrish
Allow users to more easily set single config fields.
ecaea6c 
Closes #763

Change-Id: I1918f2a5286781e81f2619296e3201f02b91128f
@joeyparrish
Copy link
Member Author

This feature will be out in v2.4 this week.

@shaka-project shaka-project locked and limited conversation to collaborators Jul 8, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
4 participants
@ismena @joeyparrish @shaka-bot @michellezhuogg