-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small MediaSource.remove()
intervals causing crashes on Cast platforms.
#6240
Labels
platform: Cast
Issues affecting Cast devices
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
I say increase it to 1.0. There's not much point in evicting 100ms of content. |
JulianDomingo
added a commit
that referenced
this issue
Feb 11, 2024
JulianDomingo
added a commit
that referenced
this issue
Feb 12, 2024
JulianDomingo
added a commit
that referenced
this issue
Feb 12, 2024
joeyparrish
pushed a commit
that referenced
this issue
Feb 12, 2024
) Increases the default required removal duration from `0.01` => `1.0`. Closes #6240.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
platform: Cast
Issues affecting Cast devices
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
N/A
What version of Shaka Player are you using?
v4.7.x
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Custom app (PlutoTV)
If custom app, can you reproduce the issue using our demo app?
N/A (cast-related)
What browser and OS are you using?
Chrome / Cast
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Chromecast Ultra
What are the manifest and license server URIs?
N/A (Load any VOD or live stream on the PlutoTV production app).
What configuration are you using? What is the output of
player.getConfiguration()
?Default shaka config.
What did you do?
What did you expect to happen?
What actually happened?
The issue is very similar to #2982. However, the eviction goal is still very small, as Shaka will attempt evictions for intervals as small as
0.01
:shaka-player/lib/media/streaming_engine.js
Lines 2348 to 2358 in 83c02b8
We've observed this is problematic for Cast platforms, as overflow durations like
0.01084400000002006
are failing downstream checks in the cast MSE implementation:It seems reasonable to make the
StreamingEngine
's eviction goal configurable, and also to set a higher default minimum interval; it doesn't make sense to spend the effort to remove durations of approx.0.01
seconds.The crashes stopped even by increasing this minimum from
0.01
=>0.10
, so the PR will provide a default value of0.10
.The text was updated successfully, but these errors were encountered: