Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaSourceEngine integration tests fail on Safari 10 #615

Closed
joeyparrish opened this issue Dec 1, 2016 · 1 comment
Closed

MediaSourceEngine integration tests fail on Safari 10 #615

joeyparrish opened this issue Dec 1, 2016 · 1 comment
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@joeyparrish
Copy link
Member

In Safari 10, MediaSourceEngine integration tests trigger failed assertions in MediaSourceEngine. Example:

Safari 10.0.1 (Mac OS X 10.12.1) MediaSourceEngine ends the stream, truncating the duration FAILED
	Failed: Spurious updateend event!
	jasmineAssert@test/test/boot.js:37:13
	onUpdateEnd_@lib/media/media_source_engine.js:682:22
	[native code]

This could indicate a bad assumption in MediaSourceEngine, an implementation bug in Safari, or a bad test. Needs investigation.
@joeyparrish joeyparrish self-assigned this Dec 1, 2016
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Dec 1, 2016
@joeyparrish
Copy link
Member Author

joeyparrish commented Dec 2, 2016 •
edited
Loading

Two bugs found in Safari 10's MSE implementation:

@joeyparrish joeyparrish modified the milestone: v2.1.0 Dec 6, 2016
ismena pushed a commit that referenced this issue Dec 15, 2016
@joeyparrish @ismena
Update MediaSource polyfills for Safari 10
e976553 
Safari 10 has some new MediaSource implementation bugs that need to
be worked around.  This updates and refactors the polyfills for Safari
10.

Bugs filed:
  https://goo.gl/qCeTZr
  https://goo.gl/rC3CLj

Closes #615

Change-Id: Id694798cd083878f337c0ba6e017fcdaac3c69be
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot