fix(Ads): Fix VMAP won't play in muted autoplay #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
theodab
requested changes
Jan 9, 2024
lib/ads/client_side_ad.js
Outdated
| /** | ||
| * @param {number} videoVolume | ||
| */ | ||
| mute(videoVolume) { |
There was a problem hiding this comment.
Okay, after some examining I agree that this method needs to exist, so that we can keep track of what the previous video volume is without actually setting the volume on the ad element.
However, this name is bad. It's very similar to the setMuted method, and doesn't really explain how the two methods are different.
Instead I'd call this something like "setInitialMuted", and add a comment to the JSDoc that it's required for a muted ad to start when autoplaying.
theodab
approved these changes
Jan 9, 2024
avelad
added a commit
that referenced
this pull request
Jan 9, 2024
avelad
added a commit
that referenced
this pull request
Jan 9, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6020
Fixes #6037