Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads don't work in iOS (but work when "Request desktop site" is on) #6037

Closed
Andekas opened this issue Jan 3, 2024 · 0 comments · Fixed by #6046
Closed

Ads don't work in iOS (but work when "Request desktop site" is on) #6037

Andekas opened this issue Jan 3, 2024 · 0 comments · Fixed by #6046
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Andekas
Copy link

Andekas commented Jan 3, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not related

What version of Shaka Player are you using?

Latest, 4.7.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Tested with both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
iOS, Safari, Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not related

What are the manifest and license server URIs?

Doesn't matter; for testing VMAP sample URLs from https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags are good

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Play video with ads using iOS device (iPhone). For testing, I added IMA sample tag to some existing demo players.

What did you expect to happen?
Preroll to play.

What actually happened?

Video starts and ads don't even get loaded.

I know that Shaka doesn't support midrolls on iOS, but previously the preroll(s) started playing. An then, using adManager event listener for shaka.ads.AdManager.AD_STOPPED it was possible to reload player with intended content. This worked in 4.3.2

With current version, ads won't load at all.

Strangely, when "Request desktop site" is on, ads (even midrolls) work great on iOS, both Chrome and Safari.

@Andekas Andekas added the type: bug Something isn't working correctly label Jan 3, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Jan 3, 2024
@Andekas Andekas changed the title Ads don't work in iOS Ads don't work in iOS (but work when "Request desktop site" is on) Jan 3, 2024
@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround platform: iOS Issues affecting iOS labels Jan 8, 2024
avelad added a commit that referenced this issue Jan 9, 2024
avelad added a commit that referenced this issue Jan 9, 2024
avelad added a commit that referenced this issue Jan 9, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants