Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLS Subtitles are not rendered within provided timestamps specified in VTT file. #2714

Closed
matejpolak opened this issue Jul 7, 2020 · 0 comments
Closed

HLS Subtitles are not rendered within provided timestamps specified in VTT file. #2714

matejpolak opened this issue Jul 7, 2020 · 0 comments
Assignees
@joeyparrish
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.1

Comments

@matejpolak
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yaes

What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=cs-CZ;textlang=cs-CZ;uilang=cs-CZ;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8;panel=ALL_CONTENT;panelData=drm:CLEAR,HLS,SUBTITLES;build=uncompiled

What version of Shaka Player are you using?
v3.0.1-uncompiled

What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.106 Safari/537.36

What did you do?
Simply play provided content and set subtitle track for English for example.

What did you expect to happen?
Subtitles being rendered on time.

What actually happened?
I'm observing wrong subtitles rendering in both Shaka Demo page and my own app using Shaka.

Subtitles are not rendered on time -> They don't respect timestamps provided in .vtt file.

Doesn't work in:

  • Chrome
  • Firefox
  • Edge

Works in:

  • Safari

Chrome
Snímek obrazovky 2020-07-07 v 15 18 37

Safari
Snímek obrazovky 2020-07-07 v 15 21 58
@michellezhuogg michellezhuogg added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles and removed needs triage labels Jul 7, 2020
@shaka-bot shaka-bot added this to the v3.1 milestone Jul 7, 2020
@joeyparrish joeyparrish added the component: HLS The issue involves Apple's HLS manifest format label Aug 12, 2020
@joeyparrish joeyparrish self-assigned this Aug 12, 2020
joeyparrish added a commit that referenced this issue Aug 12, 2020
@joeyparrish
fix(VTT): Fix timing of VTT in HLS without map header
0c16dd5 
When there is no X-TIMESTAMP-MAP header, the HLS spec states that the
client should map 0 to 0, effectively.  That means we were wrong to
offset the cues by the segment time.

Since DASH IOP states that segmented text should be packaged in MP4,
this should not affect compliant DASH content.

Closes #2714

Change-Id: Iddb00f2fd1afeb4f0f2c99f92f65e5db0e3a84f1
@shaka-project shaka-project locked and limited conversation to collaborators Oct 11, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
4 participants
@joeyparrish @shaka-bot @michellezhuogg @matejpolak