Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo version links do not load if ad-blocker is used #2669

Closed
theodab opened this issue Jun 21, 2020 · 2 comments
Closed

Demo version links do not load if ad-blocker is used #2669

theodab opened this issue Jun 21, 2020 · 2 comments
Assignees
@theodab
Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.1

Comments

@theodab
Copy link
Contributor

theodab commented Jun 21, 2020

If an ad-blocker is running, and the demo is in uncompiled mode, the player fails to load. This is expected behavior (see #2222); the fix is to run in compiled mode. However, if you are navigating to the demo page in such a situation, most of the demo page does not load: this includes the version links at the bottom, which you would normally use to navigate to the compiled version. This is kind of a problem, since the demo defaults to uncompiled mode!
We should handle such failures better, to make it easier for users to recover from such issues.
@theodab theodab added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications labels Jun 21, 2020
@theodab theodab self-assigned this Jun 21, 2020
@shaka-bot shaka-bot added this to the v3.1 milestone Jun 21, 2020
@avelad
Copy link
Member

avelad commented Jun 22, 2020

One solution might be to load the compiled version by default when an ad blocker is detected

@theodab
Copy link
Contributor Author

theodab commented Jun 22, 2020

Maybe. Right now I have a CL out for review that adds a contextual error popup, and fixes the links at the bottom so that they are visible if the load fails. I figure it could be like a learning moment, like showing the developer a good reason why they shouldn't use uncompiled mode in actual production apps? But I could see the argument either way.

joeyparrish pushed a commit that referenced this issue Jul 27, 2020
@theodab @joeyparrish
fix(demo): Fix behavior when UI fails to load
41e5206 
This modifies the demo to load localizations even when the UI fails
to load, so that the footer links will still be visible.
This also makes the footer links work in that situation, and modifies
the shaka-ui-load-failed event to return a failure reason code, so
that we can display a contextual error message in event of a failure.

Closes #2669

Change-Id: I0cf38f7e39558f1977eee490131378c32105437f
@shaka-project shaka-project locked and limited conversation to collaborators Aug 22, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
3 participants
@avelad @shaka-bot @theodab