-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - Playback rate is not updated in src mode #2488
Comments
@avelad, can you help us debug this? Try adding a listener to the video element first to see if the const video = document.querySelector('video');
video.addEventListener('ratechange', () => console.log('ratechange', video.playbackRate)); Thanks! |
I just tried in Chrome 80 and it doesn't work |
@joeyparrish the event is fired but the UI is not updated |
Excellent! Thanks for the help. I didn't think to use an mp4 to trigger src= playback in Chrome, and I had assumed this was an issue only with Safari. But if it's failing in Chrome, too, it's probably not a browser-specific quirk. I can confirm this issue in ChromeOS 80. |
I found the issue. We're actually listening for a secondary |
This fixes a missing listener for the ratechange event for src= playbacks, and also fixes a small mistake in the MediaSource setup that could have resulted in the ratechange event being triggered before playRateController_ was created. Closes #2488 Backported to v2.5.x Note that v2.5.x does not have the playback rate feature in the UI, nor the Player event for ratechange. Change-Id: If85e489d681cfbb1ae6141b490d82264e1d932bd
Have you read the FAQ and checked for duplicate open issues? Yes
What version of Shaka Player are you using? Nightly
Can you reproduce the issue with our latest release version? No
Can you reproduce the issue with the latest code from
master
? YesAre you using the demo app or your own custom app? Demo
What browser and OS are you using? Safari 13.1 macOS Catalina
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8
What did you do?
Load the previous stream in Safari (use native playback)
Change the playback rate in the UI
What did you expect to happen?
The playback rate mark is updated to the selection
What actually happened?
The playback rate mark is not updated to the selection but the playback rate in the video is changed
The text was updated successfully, but these errors were encountered: