Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Playback rate is not updated in src mode #2488

Closed
avelad opened this issue Apr 7, 2020 · 5 comments
Closed

UI - Playback rate is not updated in src mode #2488

avelad opened this issue Apr 7, 2020 · 5 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@avelad
Copy link
Member

avelad commented Apr 7, 2020

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? Nightly

Can you reproduce the issue with our latest release version? No

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Demo
What browser and OS are you using? Safari 13.1 macOS Catalina

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8

What did you do?

Load the previous stream in Safari (use native playback)
Change the playback rate in the UI

What did you expect to happen?
The playback rate mark is updated to the selection

What actually happened?

The playback rate mark is not updated to the selection but the playback rate in the video is changed

@joeyparrish
Copy link
Member

@avelad, can you help us debug this? Try adding a listener to the video element first to see if the ratechange event is firing? That's what our UI listens for.

const video = document.querySelector('video');
video.addEventListener('ratechange', () => console.log('ratechange', video.playbackRate));

Thanks!

@avelad
Copy link
Member Author

avelad commented Apr 7, 2020

I just tried in Chrome 80 and it doesn't work

@joeyparrish
Copy link
Member

Excellent! Thanks for the help. I didn't think to use an mp4 to trigger src= playback in Chrome, and I had assumed this was an issue only with Safari. But if it's failing in Chrome, too, it's probably not a browser-specific quirk.

I can confirm this issue in ChromeOS 80.

@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Apr 7, 2020
@joeyparrish joeyparrish self-assigned this Apr 7, 2020
@joeyparrish
Copy link
Member

I found the issue. We're actually listening for a secondary ratechange event from the Player, since the Player uses playbackRate to manage buffering states. The setup for that is broken in the src= path specifically.

@shaka-bot shaka-bot added this to the v2.6 milestone Apr 7, 2020
@joeyparrish joeyparrish added the component: UI The issue involves the Shaka Player UI label Apr 7, 2020
joeyparrish added a commit that referenced this issue Apr 10, 2020
This fixes a missing listener for the ratechange event for src=
playbacks, and also fixes a small mistake in the MediaSource setup
that could have resulted in the ratechange event being triggered
before playRateController_ was created.

Closes #2488

Backported to v2.5.x

Note that v2.5.x does not have the playback rate feature in the UI,
nor the Player event for ratechange.

Change-Id: If85e489d681cfbb1ae6141b490d82264e1d932bd
@shaka-project shaka-project locked and limited conversation to collaborators Jun 7, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants