-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: "Failed to execute send on PresentationConnection", when Chromecast left idle. #2446
Comments
I'm working on repro with the nightly build right now. If I can't reproduce on the nightly build, I'll try again with v2.5.9. |
Confirmed on the nightly build. I forgot to pause the video, but the error occurred anyway. My steps:
The UI doesn't respond to the giant play/pause button. |
The stack trace looks much as described by @londonshliach. I see that on this line: the method throws an error on timeout rather than calling the error callback we gave it. The fact that it throws feels like a Chromecast SDK bug. But that doesn't explain why we're unable to recover. |
I can reproduce the issue with only 10 minutes of lock time. |
When a mobile device goes idle, the Cast connection can be terminated without explicitly closing it. When this happens, the Cast session is unusable and throws exceptions. This changes CastSender to correctly detect and recover from such a problem by disconnecting explicitly and dispatching an Error to the application. This also fixes the disconnection process so that playback can be correctly resumed on the local device. Closes #2446 Backported to v2.5.x Change-Id: I59f51a1e911199eee22693e7db4ab39855de0298
Have you read the FAQ and checked for duplicate open issues?
Yes.
What version of Shaka Player are you using?
2.5.9
Can you reproduce the issue with our latest release version?
Yes.
Are you using the demo app or your own custom app?
Both.
What browser and OS are you using?
Chrome on Android, and Chromecast.
What are the manifest and license server URIs?
I used the Angel One Manifest on the Shaka demo page.
https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd
What did you do?
⋮
button).What did you expect to happen?
I expected it to either play the video on my Chromecast device, or to show that it was disconnected and play the video on my phone.
What actually happened?
It showed that I was still connected, but it wouldn't play.
The text was updated successfully, but these errors were encountered: