Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTCTiming is ignored when using SegmentTimeline even when autoCorrectDrift is off #2411

Closed
thmatuza opened this issue Feb 21, 2020 · 2 comments
Closed

UTCTiming is ignored when using SegmentTimeline even when autoCorrectDrift is off #2411

thmatuza opened this issue Feb 21, 2020 · 2 comments
Assignees
@thmatuza
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@thmatuza
Copy link
Contributor

thmatuza commented Feb 21, 2020 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v2.5.9

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
The demo app

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Chrome, macOS Catalina

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

https://live.unified-streaming.com/scte35/scte35.isml/.mpd

What did you do?

  1. Open the demo page
  2. Uncheck Auto-Correct DASH Drift config
  3. Start playing the manifest url above on the demo player.

What did you expect to happen?
It will call a request to https://time.akamai.com/?iso

What actually happened?

No UTCTiming request is called
@thmatuza thmatuza mentioned this issue Feb 21, 2020
Merged
@thmatuza
Copy link
Contributor Author

I created a pull request here.
#2412

@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Feb 26, 2020
@joeyparrish joeyparrish added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Feb 26, 2020
@joeyparrish joeyparrish added this to the v2.6 milestone Feb 26, 2020
@joeyparrish
Copy link
Member

Thank you for the report and the PR! After having analyzed the code a bit, I think you are correct that this is a bug.

joeyparrish pushed a commit that referenced this issue Mar 18, 2020
@thmatuza @joeyparrish
Fix the bug that UTCTiming is ignored even when autoCorrectDrift is o…
62c0b3a 
…ff (#2412)

Backported to v2.5.x

Closes #2411

Change-Id: Id580fab5e505bd13810ba20dac705076ad4bb964
@shaka-project shaka-project locked and limited conversation to collaborators Apr 26, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thmatuza thmatuza

Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@thmatuza @joeyparrish @shaka-bot