Support of fontSize cellResolution units in TTML subtitles #2403
Labels
component: captions/subtitles
The issue involves captions or subtitles
component: TTML
The issue involves TTML subtitles specifically
status: archived
Archived and locked; will not be updated
type: enhancement
New feature or request
Milestone
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v2.5.9
Please ask your question
Hi,
According to the TTML spec fontSize
https://www.w3.org/TR/ttml1/#style-attribute-fontSize
fontSize value can be percentage or scalar in the next units
https://www.w3.org/TR/ttml1/#style-value-length
We have ttml subs with the next styles
tts:fontSize="0.80c" is in cellResolution units
We are using the default shaka.text.TtmlTextParser
And seems like fontSize will not be provided to the text displayer in this case, as now default TtmlTextParser does not support cellResolution units for the font size.
https://github.com/google/shaka-player/blob/697a6ff785046dff3b7dea1d44fc8fc87cee925b/lib/text/ttml_text_parser.js#L531-L535
https://github.com/google/shaka-player/blob/697a6ff785046dff3b7dea1d44fc8fc87cee925b/lib/text/ttml_text_parser.js#L971-L977
Is it possible to add the support of fontSize cellResolution units to TtmlTextParser?
Thanks!
The text was updated successfully, but these errors were encountered: