Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectTextLanguage while not displaying text doesn't update active track #2010

Closed
anuragkalia opened this issue Jun 24, 2019 · 0 comments
Closed

selectTextLanguage while not displaying text doesn't update active track #2010

anuragkalia opened this issue Jun 24, 2019 · 0 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@anuragkalia
Copy link

Have you read the FAQ and checked for duplicate open issues?

Yes
What version of Shaka Player are you using?
Latest

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes.

Are you using the demo app or your own custom app?
Demo app.

What browser and OS are you using?
Chrome, Mac

What did you do?

  1. Open https://shaka-player-demo.appspot.com/demo/#audiolang=en-GB;textlang=en-GB;uilang=en-GB;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;panel=SEARCH;build=uncompiled
  2. Run shakaDemoMain.player_.selectTextLanguage('el') in console.
  3. Run shakaDemoMain.player_.getTextTracks() in console.

What did you expect to happen?
I expected ‘el’ to be the active text track.

What actually happened?
But ‘en’ is the active text track instead of ‘el’. This is happening because in chooseStreamsAndSwitch_, we do not switch the text stream if it is not visible. That logic is also responsible for updating the active text stream.
@anuragkalia anuragkalia changed the title Changing text track while text tracks are not visible does not change the active text track If we select the text language when text tracks are not visible, the active text track in getTextTracks does not update Jun 24, 2019
@anuragkalia anuragkalia changed the title If we select the text language when text tracks are not visible, the active text track in getTextTracks does not update If we select the text language when text tracks are not visible, the active text track in “getTextTracks()” does not update Jun 24, 2019
@TheModMaker TheModMaker changed the title If we select the text language when text tracks are not visible, the active text track in “getTextTracks()” does not update selectTextLanguage while not displaying text doesn't update active track Jun 26, 2019
@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Jun 26, 2019
@TheModMaker TheModMaker added this to the v2.6 milestone Jun 26, 2019
@TheModMaker TheModMaker self-assigned this Jun 26, 2019
TheModMaker added a commit that referenced this issue Jul 3, 2019
@TheModMaker
Avoid changing variant when switching text lang.
56d0214 
This fixes a TODO and fixes setting the "active" track when switching
languages when not displaying text.

Fixes #2010

Change-Id: Ic4cf4126ffb9b93a09af998e20f9da0e7af852fb
AnteWall pushed a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
@TheModMaker @AnteWall
Avoid changing variant when switching text lang.
d749f9c 
This fixes a TODO and fixes setting the "active" track when switching
languages when not displaying text.

Fixes shaka-project#2010

Change-Id: Ic4cf4126ffb9b93a09af998e20f9da0e7af852fb
@shaka-project shaka-project locked and limited conversation to collaborators Aug 26, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@anuragkalia @TheModMaker @shaka-bot