-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't compile using latest NPM version #1758
Comments
It looks like we can't handle the version number of your npm install. Are you using a pre-release or compiled from source version of npm? What is the output of |
I am using the latest version from Node's site.
|
Alright.. It seems to be working now. I'll close this issue here in a bit if it compiles correctly. |
We can fix it to work with the latest NPM version. But at least there's a workaround in the meantime. |
Resolved temporarily (until changes are commited) by using the following version of NodeJS: v10.15.0 (https://nodejs.org/dist/v10.15.0/node-v10.15.0-linux-x64.tar.xz) |
Should be easy to fix. |
Prereleases and other build metadata can come after the three numeric parts of the version, separated by a hyphen. This fixes both parsing and sorting of these versions. Fixes #1758 Change-Id: I6e24f1a96a19204178eef014e2765fc40ccb48e8
Fix cherry-picked for v2.4.6. |
Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
Latest from GitHub at the time of this post.
Can you reproduce the issue with our latest release version?:
I am using the latest..
Can you reproduce the issue with the latest code from
master
?:I am using the latest from master..
Are you using the demo app or your own custom app?:
I am compiling..
If custom app, can you reproduce the issue using our demo app?:
N/A
What browser and OS are you using?:
Debian 9
What are the manifest and license server URIs?:
N/A
What did you do?
I tried compiling Shaka following these instructions: https://shaka-player-demo.appspot.com/docs/api/tutorial-welcome.html
What did you expect to happen?
I expected Shaka to compile.
What actually happened?
Shaka did not compile..
The text was updated successfully, but these errors were encountered: