Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative MPD/Location URLs not work. #1668

Closed
agelun opened this issue Nov 15, 2018 · 2 comments
Closed

Relative MPD/Location URLs not work. #1668

agelun opened this issue Nov 15, 2018 · 2 comments
Assignees
@michellezhuogg
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.5

Comments

@agelun
Copy link

agelun commented Nov 15, 2018

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
commit 1831ce9

Can you reproduce the issue with the latest code from master?:
Yes

Are you using the demo app or your own custom app?:
Demo app

What browser and OS are you using?:
Chrome

What did you do?
Trying to play content with relative URL in Location tag.

What did you expect to happen?
Content plays normally.

What actually happened?
Shaka's URL using as a base URL for next playlist and chunks requests. Content playback doesn't work.
Relative URLs are not supported in Location tag now – only absolute ones.
agelun pushed a commit to smartlabstv/shaka-player that referenced this issue Nov 15, 2018
Fix: shaka-project#1668 Relative MPD/Location URLs not work
f0b47d2
@joeyparrish joeyparrish added type: bug Something isn't working correctly flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this and removed needs triage labels Nov 19, 2018
@joeyparrish
Copy link
Member

Hi @agelun. I see you've already made a fix in your fork: smartlabstv@f0b47d2

Could you please add a unit test in test/dash/ and submit a pull request? Thanks!

@shaka-bot shaka-bot added this to the v2.5 milestone Nov 19, 2018
@michellezhuogg michellezhuogg self-assigned this Dec 4, 2018
joeyparrish pushed a commit that referenced this issue Jan 17, 2019
@michellezhuogg @joeyparrish
Fix relative location urls
17f58d9 
Fixes #1668

Change-Id: Ib9e1a19254f1829795bd69cc930d21f33e136980
@joeyparrish joeyparrish removed the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Jan 22, 2019
@joeyparrish
Copy link
Member

Fix cherry-picked for v2.4.6.

@shaka-project shaka-project locked and limited conversation to collaborators Feb 5, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellezhuogg michellezhuogg

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
4 participants
@agelun @joeyparrish @shaka-bot @michellezhuogg