-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS with VTT in MP4: Subtitle rendition not shown during playback #1270
Comments
The problem is that it doesn't have a |
VTT in MP4 should have a codecs attribute of 'wvtt', right? @kqyang, I believe that should be added if it's missing. |
I actually tried adding wvtt codec: https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/wvtemp/kqyang/vtt11/bunny_vtt_master.m3u8;lang=en-US;build=uncompiled I am seeing a different error this time: Shaka Error TEXT.INVALID_MP4_VTT. |
First I think you put the The logs show |
#EXT-X-MEDIA does not have CODECS attribute. For HLS, the codec is specified on the variant stream #EXT-X-STREAM-INF. It does not mean that they are multiplexed in the same container.
There is a init segment specified: #EXT-X-MAP:URI="bunny_text.mp4" |
It is tricky to take a list of codecs and figure out which goes to which stream. It is one of the ways in which HLS can be more challenging than DASH. We have a whitelist of audio & video codecs in the HLS parser to help with that. We may need to expand it to text. |
Wait, actually, we already have that. Something strange is going on. |
Our HLS parser made init segment references for everything but text streams. This condition was unnecessary, and the createInitSegmentReference_ method already returns null if there is no init segment specified in the playlist. Backported to v2.3.x Closes #1270 Change-Id: Ia9e92a561dc0f9ee3caccfac30f3fb936d9dac87
Fixed, and cherry-picked to v2.3.3. |
NOTE: For bugs, if you delete this template, we will send it again and ask you to fill it out.
Have you read the FAQ and checked for duplicate open issues?:
Yes.
What version of Shaka Player are you using?:
Public demo.
Can you reproduce the issue with our latest release version?:
Yes.
Can you reproduce the issue with the latest code from
master
?:Yes.
Are you using the demo app or your own custom app?:
Demo app.
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?:
Chrome in Linux.
What are the manifest and license server URIs?:
(NOTE: you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)
(NOTE: a copy of the manifest text or an attached manifest will not be enough to reproduce your issue, and we will ask you to send a URI instead)
https://storage.googleapis.com/wvtemp/kqyang/vtt6/bunny_vtt_master.m3u8
What did you do?
Play: https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/wvtemp/kqyang/vtt6/bunny_vtt_master.m3u8;lang=en-US;build=uncompiled
What did you expect to happen?
CC button in seek bar to enable / disable subtitles.
What actually happened?
Not seeing CC button.
It is possible that there is a problem with the content. Let me know where the problem is or why the player does it like it if that is the case.
The player should also display or log an error instead of failing silently.
The text was updated successfully, but these errors were encountered: