"The command line is too long" from build\all.py

[sandersaares]

I pulled latest master branch and got the error below when running build\all.py.

This is on Windows 10 v1709.

c:\Source\shaka-player>c:\Python27\python.exe build\all.py
[INFO] Generating Closure dependencies...
[INFO] Running Closure Compiler linter...
[INFO] Running eslint...
The command line is too long.

The script stops at the above point.

[joeyparrish]

Here are some numbers on command-line length taken from my workstation. These depend on the state of the project today, the length of the path to my working directory, and other factors. But these should provide a sense of scale.

step	command length
Generating Closure dependencies	162
Running Closure Compiler linter	17776
Running eslint	17760
Running htmlhint	347
Checking the tests for type errors	17842
Checking the usability of generated externs	9615 + 2097
Compiling the library (debug)	10369 + 9624
Compiling the demo app (debug)	3114
Compiling the receiver app (debug)	2767
Compiling the library (release)	10455 + 9618
Compiling the demo app (release)	3096
Compiling the receiver app (release)	2749

Windows has an 8kB limit on command line length. It's not clear to me why we would have only recently started tripping over this limit, or if there are any exceptions. All of these commands are invoked from python using subprocess.Popen with an argument array.

[joeyparrish]

The problem seems to come from the addition of eslint, specifically. It's the long list of files, combined with the use of node_modules/.bin/eslint.cmd on Windows. The cmd script passes through the arguments, which breaks the command-line limit. python's subprocess.Popen is not what triggers the error.

[joeyparrish]

Related to work on issue #1157

[joeyparrish]

Cherry-picked to v2.3.1.