Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: youtube alt #138

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat: youtube alt #138

merged 1 commit into from
Jan 21, 2025

Conversation

Omikorin
Copy link
Contributor

@Omikorin Omikorin commented Jan 3, 2025

This PR adds very popular Youtube alternative style.

The example of another website using it can be seen here.

That's how it looks on light theme:
image

and dark:
image


It's simply a red color but has bad WCAG status. We could change it a little bit to be more compatible.

#FF0000 example:

image

The first possible solution is #EB0000:

image

Full WCAG compatibile option doesn't look like Youtube #B30000:

image

So, I suggest using #E60000 as it is a bit darker than the minimal solution and I found it optimal for me too.

Let me know what do you think, then I'll update the PR.

@sethcottle sethcottle merged commit 2f8ddfa into sethcottle:main Jan 21, 2025
@sethcottle
Copy link
Owner

@Omikorin thanks for this PR! Sorry for the delay on getting to this—took a little time for the holidays. The #FF0000 isn't optimal, but my general rule of thumb is not to tweak brand colors and use them to the best they're able to be, which isn't always accessible. There are a few branded buttons within LittleLink that fail contrast checks, and that's just a symptom of is what it is with the brand colors IMO. I'm going to go ahead and merge this in since this is generally a common alternative with this color scheme!

@Omikorin Omikorin deleted the feat/youtube-alt branch January 21, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants