write binding tests and cleanup #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reconbot
commented
May 15, 2016
•
reconbot
commented
- Fix bug where write callback was being called multiple times when write operations blocked
- [windows] refactored write code to be less complex
- added arduino required integration tests
| @@ -364,7 +364,7 @@ The `buffer` parameter accepts a [`Buffer` ](http://nodejs.org/api/buffer.html) | |||
|
|
|||
| **_callback (optional)_** | |||
|
|
|||
| Called once the write operation returns. The callback should be a function that looks like: `function (error, bytesWritten) { ... }` | |||
| Called once the write operation returns. The callback should be a function that looks like: `function (error) { ... }` | |||
There was a problem hiding this comment.
I've removed the bytes written argument from the callback as it was usually a lie because the callback was called over and over and reported on each write. It should always match the length of the bytes you gave it to write. It's possible to put this back but not easy and not useful?
This was referenced May 16, 2016
|
You can test this branch by changing your package.json to include |
reconbot
force-pushed
the
write-bindings
branch
2 times, most recently
from
4d38b39 to
a8451c3
Compare
- Fix bug where write callback was being called multiple times when write operations blocked - [windows] refactored write code to be less complex - [unix] refactored write code to be less complex - added arduino required integration tests
reconbot
changed the title
reconbot
added a commit
that referenced
this pull request
Jul 24, 2018
- Fix bug where write callback was being called multiple times when write operations blocked - [windows] refactored write code to be less complex - [unix] refactored write code to be less complex - added arduino required integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.