feat: Make FullEvent serializeable #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
|
...Whats the usecase here? Seems like you're trying to do something the library isn't designed for and you would probably have a better experience using twilight instead of creating a hacky solution with serenity. |
|
I've talked in DMs about this, it's for serializing to an interpreter and removes 3k LOC with the only downside being slightly longer fresh compile times. I'm good with this. |
|
I'll enable auto merge, but you can have the final say on approving. @jamesbt365 |
jamesbt365
reviewed
Oct 31, 2024
auto-merge was automatically disabled
October 31, 2024 00:38
Head branch was pushed to by a user without write access
jamesbt365
approved these changes
Oct 31, 2024
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
GnomedDev
pushed a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 1, 2025
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.