Remove Value from Http #2806
Merged
Remove Value from Http #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
force-pushed
the
next
branch
3 times, most recently
from
aa90cc6 to
276c192
Compare
arqunis
added
enhancement
arqunis
approved these changes
Mar 28, 2024
mkrasnitski
reviewed
Mar 30, 2024
Comment on lines
-180
to
+182
| http.edit_role_position(guild_id, role.id, position, self.audit_log_reason).await?; | ||
| guild_id | ||
| .edit_role_position_with_reason(http, role.id, position, self.audit_log_reason) | ||
| .await?; |
There was a problem hiding this comment.
This introduced a dependency on the model feature inside code that is normally just gated behind http plus builder. Is it possible to fix this?
There was a problem hiding this comment.
I'm going to make a PR soon that moves builder inside of model and gets rid of the builder feature, since builder shouldn't be used without model anyway.
There was a problem hiding this comment.
Can you elaborate? I'm thinking of the builder-no-http usecase as a specific counter-example to that idea.
EDIT: It would be feasible to gate the execute methods behind model instead of just http, but the structs themselves I don't think should be gated behind model.
There was a problem hiding this comment.
Let's move this to the lib-development chat as this is going quite off-topic for this PR.
GnomedDev
added a commit
that referenced
this pull request
Mar 31, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 31, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Apr 1, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
May 14, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
that referenced
this pull request
May 14, 2024
GnomedDev
added a commit
that referenced
this pull request
May 23, 2024
GnomedDev
added a commit
that referenced
this pull request
May 28, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 9, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
that referenced
this pull request
Jun 22, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 22, 2024
This avoids allocating instances of `serde_json::Value`s.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 29, 2024
This avoids allocating instances of `serde_json::Value`s.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 30, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
that referenced
this pull request
Aug 16, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
that referenced
this pull request
Oct 20, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
This avoids allocating instances of `serde_json::Value`s.
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
This avoids allocating instances of `serde_json::Value`s.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
This avoids allocating instances of `serde_json::Value`s.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
This avoids allocating instances of `serde_json::Value`s.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 1, 2025
This avoids allocating instances of `serde_json::Value`s.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 14, 2025
This avoids allocating instances of `serde_json::Value`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids allocating serde_json::Value