Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Arc<str> to store the token #2745

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Use Arc<str> to store the token #2745

merged 1 commit into from
Jan 29, 2024

Conversation

GnomedDev
Copy link
Member

SecretString is nice to have, but this is more efficient, and SecretString is defense in depth we can do without.

@github-actions github-actions bot added http Related to the `http` module. gateway Related to the `gateway` module. labels Jan 28, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jan 29, 2024
@GnomedDev GnomedDev merged commit a7e405e into serenity-rs:next Jan 29, 2024
21 checks passed
@GnomedDev GnomedDev deleted the token-arc branch January 29, 2024 18:48
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
9e47142 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Use Arc<str> to store the token (serenity-rs#2745)
8ef2553 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
561d629 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
294aac2 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
73559cd 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
cfd7e4d 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
73c72eb 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
b657345 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
d6fdee6 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
d41f466 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
f9b12f7 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
eb8effd 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
81d3a91 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
51c320b 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
800eef5 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
16efddb 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
26278e8 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
5f9a1bf 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
32f7a8a 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
b90fac8 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
db821e8 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
9c20ce7 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
4b20c1d 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Use Arc<str> to store the token (serenity-rs#2745)
468e4de 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Use Arc<str> to store the token (serenity-rs#2745)
f3002ae 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
d50abbd 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
6c376c9 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
c2ea529 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
8b41c32 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
1fe6850 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Use Arc<str> to store the token (#2745)
309ae56 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Use Arc<str> to store the token (serenity-rs#2745)
09b031f 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Use Arc<str> to store the token (serenity-rs#2745)
adfc0d5 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Use Arc<str> to store the token (serenity-rs#2745)
0151fe7 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Use Arc<str> to store the token (serenity-rs#2745)
dbae7b3 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 14, 2025
@GnomedDev @mkrasnitski
Use Arc<str> to store the token (serenity-rs#2745)
207ae15 
`SecretString` is nice to have, but this is more efficient, and
`SecretString` is defense in depth we can do without.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. gateway Related to the `gateway` module. http Related to the `http` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis