Remove typemap without making everything generic #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
client
GnomedDev
force-pushed
the
no-typemap-generic
branch
from
1e05112 to
6fbebc6
Compare
arqunis
added
enhancement
GnomedDev
force-pushed
the
no-typemap-generic
branch
from
6fbebc6 to
a59c477
Compare
arqunis
approved these changes
Jan 16, 2024
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 22, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Feb 9, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
arqunis
pushed a commit
that referenced
this pull request
Mar 1, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 10, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 11, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 11, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 13, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 13, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 19, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 19, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 21, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 25, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 29, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Mar 31, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 31, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Apr 1, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
May 14, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
May 14, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
May 23, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
May 28, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 9, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Jun 22, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Jun 22, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 29, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 30, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Aug 16, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Oct 20, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jan 16, 2025
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 1, 2025
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 14, 2025
Replaces the typemap with `dyn Any`, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the typemap with
dyn Any, which is what typemap used internally anyway. This gives the user more control over locking, removes boilerplate, and is less confusing for beginners to learn.