Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NonMax to signal builder range constraints #2703

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Use NonMax to signal builder range constraints #2703

merged 1 commit into from
Jan 14, 2024

Conversation

GnomedDev
Copy link
Member

No description provided.

@github-actions github-actions bot added the builder Related to the `builder` module. label Jan 9, 2024
@mkrasnitski
Copy link
Collaborator

Are we sure we want to expose a third-party type to the user like this? What's it like to convert from primitive ints to NonMax versions?

@GnomedDev
Copy link
Member Author

We have already exposed it to users in many model types, constructing them is the same as NonZero.

@mkrasnitski
Copy link
Collaborator

At least for those it's easy to just call .into() on them. However, constructing them requires importing the type from nonmax. Also, we're not even limiting the value ranges (except for MAX), only signalling that Discord has a narrower range than all of u16 for instance. IMO in terms of using "ranged ints", this feels like a half-measure.

@GnomedDev
Copy link
Member Author

It is a half measure, and signalling that discord has a narrower range than u16 is exactly what is required to get someone to read the docs. It isn't easy to just call .into() for non zero types, that isn't an impl.

@mkrasnitski
Copy link
Collaborator

What do you mean? Every NonMax* provides an implementation of impl From<NonMax*> for *

@GnomedDev
Copy link
Member Author

Ah, you meant getting the value out of a NonMax.

@github-actions github-actions bot added the examples Related to Serenity's examples. label Jan 10, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jan 14, 2024
@arqunis arqunis merged commit b04e308 into serenity-rs:next Jan 14, 2024
22 checks passed
@GnomedDev GnomedDev deleted the nonmax-between branch January 14, 2024 12:58
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Use NonMax to signal builder range constraints (serenity-rs#2703)
c12b8d0
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Use NonMax to signal builder range constraints (serenity-rs#2703)
80435a5
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
e61ccf5
arqunis pushed a commit that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Use NonMax to signal builder range constraints (#2703)
f01dbed
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
d1ab724
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
ccb4ce2
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
e863f84
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
6f989f8
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
d4ca1ef
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
bbeaa5d
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
4ef94ce
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
91dfb1c
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
09cca6c
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
95b11f3
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
f88d5bc
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
7b6acb3
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
745acbc
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
cc7d429
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
32f110f
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
835fc1d
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
ccc82bf
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
06c2c5e
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
be6525f
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
de32674
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Use NonMax to signal builder range constraints (serenity-rs#2703)
a3e0624
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Use NonMax to signal builder range constraints (serenity-rs#2703)
f98c27d
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
503aaf0
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
59ca730
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
f97cbe1
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
99018cc
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
af3d1ce
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Use NonMax to signal builder range constraints (#2703)
0bcaad5
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Use NonMax to signal builder range constraints (serenity-rs#2703)
ca358bc
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Use NonMax to signal builder range constraints (serenity-rs#2703)
8490ad6
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Use NonMax to signal builder range constraints (serenity-rs#2703)
12ed84d
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Use NonMax to signal builder range constraints (serenity-rs#2703)
552ce64
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 14, 2025
@GnomedDev @mkrasnitski
Use NonMax to signal builder range constraints (serenity-rs#2703)
3ba0b94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity. examples Related to Serenity's examples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GnomedDev @mkrasnitski @arqunis