New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the duplicate users cache #2662

Merged

arqunis merged 1 commit into serenity-rs:next from GnomedDev:remove-users-cache

Dec 28, 2023

Member

GnomedDev commented Dec 13, 2023 •

edited

Loading

This cache was just duplicating information already in Guild::members and therefore should be removed. This saves 700mb for my bot (pre-fixedstring). This has to refactor content_safe to always take a Guild instead of Cache, but in practice it was mostly pulling from guild cache and this means it is more likely to respect nicknames and other information, while losing the ability to clean mentions from DMs (which don't matter).

github-actions bot added model cache utils examples labels

GnomedDev force-pushed the remove-users-cache branch from 77c480f to 03e2d39 Compare

December 13, 2023 11:54


          Get rid of the duplicate users cache

GnomedDev force-pushed the remove-users-cache branch from 03e2d39 to 9765654 Compare

December 28, 2023 01:05

arqunis added enhancement breaking change labels

arqunis approved these changes

View reviewed changes

arqunis merged commit c0ab15a into serenity-rs:next

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

cf66540

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

fb9cc79

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

9c13cd0

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev deleted the remove-users-cache branch

January 14, 2024 10:26

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

5cc4e70

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

371e77c

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

90d8a39

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

7055a6e

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

5fa809a

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

45b3638

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

88ef106

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed. 

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

b1c51e3

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

f381f1e

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

5da921a

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

jamesbt365 mentioned this pull request

Correct docs for UserId::to_user #2809

Merged

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

0ced192

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

4fe1897

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

08d9ab1

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

2eaf32a

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit that referenced this pull request


          Correct documentation for UserId::to_user (#2809)

32f5de1

The documentation was never updated after #2662 removed the user cache.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

6f71c37

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

cbf605c

The documentation was never updated after serenity-rs#2662 removed the user cache.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

864b3c9

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

The documentation was never updated after serenity-rs#2662 removed the user cache.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

f2fd428

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

fd045a0

The documentation was never updated after serenity-rs#2662 removed the user cache.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

1fd7b6c

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit that referenced this pull request


          Correct documentation for UserId::to_user (#2809)

edc3707

The documentation was never updated after #2662 removed the user cache.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

936788e

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

cef0302

The documentation was never updated after serenity-rs#2662 removed the user cache.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

c07fee4

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

87669e2

The documentation was never updated after serenity-rs#2662 removed the user cache.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

c6d9a94

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit that referenced this pull request


          Correct documentation for UserId::to_user (#2809)

69bd078

The documentation was never updated after #2662 removed the user cache.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

f2b4962

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

4be01f3

The documentation was never updated after serenity-rs#2662 removed the user cache.

GnomedDev added a commit that referenced this pull request


          Get rid of the duplicate users cache (#2662)

eda0998

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit that referenced this pull request


          Correct documentation for UserId::to_user (#2809)

18dd2f3

The documentation was never updated after #2662 removed the user cache.

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

4ee1f9e

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

1c66822

The documentation was never updated after serenity-rs#2662 removed the user cache.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

48774e8

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

6a9bfec

The documentation was never updated after serenity-rs#2662 removed the user cache.

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

cd65f37

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

arqunis pushed a commit to arqunis/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

866c6f0

The documentation was never updated after serenity-rs#2662 removed the user cache.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

877dd44

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

cc119f4

The documentation was never updated after serenity-rs#2662 removed the user cache.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Get rid of the duplicate users cache (serenity-rs#2662)

a5d83ab

This cache was just duplicating information already present in `Guild::members`
and therefore should be removed.

This saves around 700 MBs for my bot (pre-`FixedString`).

This has to refactor `utils::content_safe` to always take a `Guild` instead
of`Cache`, but in practice it was mostly pulling from the guild cache anyway
and this means it is more likely to respect nicknames and other information,
while losing the ability to clean mentions from DMs, which do not matter.

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Correct documentation for UserId::to_user (serenity-rs#2809)

49ac2aa

The documentation was never updated after serenity-rs#2662 removed the user cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change cache enhancement examples model utils