Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onboarding configuration E2E test #42

Merged

Conversation

mescalantea
Copy link
Contributor

What is the goal?

Add Onboarding configuration E2E test

References

  • Issue: PAR-372

How is it being implemented?

This pull request introduces new end-to-end (E2E) tests for the configuration onboarding process and updates the test fixtures to support these new tests. The most important changes include adding a new test specification file, updating the test configuration, and modifying the test fixtures to include the onboarding settings page.

How is it tested?

Automatic tests

How is it going to be deployed?

Standard deployment

@mescalantea mescalantea requested a review from m1k3lm February 5, 2025 16:55
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be viable to use this kind of tests to configure the credentials for test instead of having sql code hardcoded in the configuration tasks like https://github.com/sequra/magento2-core/blob/master/.docker/magento/HelperModule/Sequra/Helper/Model/Task/ConfigureDummyTask.php ?

@mescalantea mescalantea merged commit 5a7d9e8 into master Feb 6, 2025
6 checks passed
@mescalantea mescalantea deleted the feature/PAR-372-E2E-tests-for-Configuration-onboarding branch February 6, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants