Migrate Magento 2 Docker image #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and teardown script improvements
…and add new entrypoint script for Magento 2 installation
|
Great work Michel. |
m1k3lm
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
The Docker image currently used for development and testing is not longer maintained by Bitnami. Create a custom Docker image that meets our requirements and migrate the existing project to use the new image in place of the current one.
References
How is it being implemented?
This pull request includes significant changes to the Docker setup for Magento, including the addition of new Dockerfiles for PHP 7.4 and PHP 8, a new helper module, and a build script. The most important changes are detailed below.
Dockerfile Additions:
.docker/magento/Dockerfile.php74).docker/magento/Dockerfile.php8)Helper Module:
.docker/magento/HelperModule/Sequra/Helper/Console/Setup.php)composer.jsonfor the new helper module. (.docker/magento/HelperModule/Sequra/Helper/composer.json).docker/magento/HelperModule/Sequra/Helper/etc/config.xml,crontab.xml,di.xml,events.xml,module.xml,registration.php) [1] [2] [3] [4] [5] [6]Build Script:
.docker/magento/build-image.sh)Additional Configurations:
.docker/magento/docker-php-m2.ini).docker/magento/m2-entrypoint.php74.sh)Opportunistic refactorings
Unused scripts were removed.
Caveats
Magento 2.4.3 image is not supported, because an Out of Memory error on runtime at the entrypoint script, that appears when composer is installing the modules. Seems that the root of the issue is the use of composer v1 instead of v2 for that particular Magento version. Some attempts to force the v2 were made without success.
Does it affect (changes or update) any sensitive data?
How is it tested?
Manual tests
How is it going to be deployed?
Standard deployment