Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional rate limit support. #249

Merged
merged 4 commits into from
Dec 21, 2017
Merged

Adding optional rate limit support. #249

merged 4 commits into from
Dec 21, 2017

Conversation

andy-trimble
Copy link
Contributor

Added an asynchronous execution method that will retry in the event of a rate limit event.

This solves the following issue: #169

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2017
@andy-trimble
Copy link
Contributor Author

@thinkingserious @mbernier If this pattern is acceptable, I'll begin porting it to the other libraries.

@mbernier
Copy link
Contributor

Oh man this is cool.

@thinkingserious what was the process in the other lib? Was it sendgrid-csharp that built this in?

@mbernier mbernier added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 11, 2017
@andy-trimble
Copy link
Contributor Author

@mbernier Here's a potential Go implementation as well.

@thinkingserious
Copy link
Contributor

In C#: sendgrid/sendgrid-csharp#369
In PHP: sendgrid/sendgrid-php#453
Convo started in Ruby: sendgrid/sendgrid-ruby#119

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 16, 2017
@thinkingserious thinkingserious merged commit 0f23918 into master Dec 21, 2017
@thinkingserious
Copy link
Contributor

Hello @andy-trimble,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Fantastic work @andy-trimble!

If you get a moment, would you mind throwing an example in here? Thanks!

@childish-sambino childish-sambino deleted the rate_limit branch January 16, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants