Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support context.Context #433

Merged
merged 1 commit into from
May 3, 2021
Merged

feat: support context.Context #433

merged 1 commit into from
May 3, 2021

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Apr 29, 2021 •
edited
Loading

Add SendWithContext, MakeRequestWithContext, MakeRequestRetryWithContext and MakeRequestAsyncWithContext.

closes #403

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 29, 2021
@johejo johejo force-pushed the support_context branch 2 times, most recently from 0e124c9 to 0af3ca9 Compare April 29, 2021 09:18
JenniferMah
JenniferMah reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johejo thanks for your PR! Can you add some tests that include a basic request with and without context?

@johejo
feat: support context.Context
098255a 
Add SendWithContext, MakeRequestWithContext, MakeRequestRetryWithContext and MakeRequestAsyncWithContext.

Closes sendgrid#403
@johejo johejo force-pushed the support_context branch from 0af3ca9 to 098255a Compare May 1, 2021 06:49
@johejo
Copy link
Contributor Author

johejo commented May 1, 2021 •
edited
Loading

@JenniferMah
Tests without context are covered by existing test cases, so I added a case to cancel in MakeRequestRetryWithContext.

@johejo johejo requested a review from JenniferMah May 1, 2021 07:20
JenniferMah
JenniferMah approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@JenniferMah JenniferMah merged commit 886bfa1 into sendgrid:main May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniferMah JenniferMah JenniferMah approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linking a context object with the request
3 participants
@johejo @JenniferMah @thinkingserious