-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support and example for secure webhook feature #389
Conversation
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 72.47% 72.57% +0.09%
==========================================
Files 3 4 +1
Lines 476 485 +9
==========================================
+ Hits 345 352 +7
- Misses 127 128 +1
- Partials 4 5 +1
Continue to review full report at Codecov.
|
good work @brpat07! this LGTM, but should we add a unit test for getting the public key? |
I haven't added any code related to getting the public key, other then the example; so it does not make sense to add the unittest for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes
Adding support and example for the feature of secure webhook
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.