Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support and example for secure webhook feature #389

Merged
merged 5 commits into from
May 4, 2020

Conversation

brpat07
Copy link
Contributor

@brpat07 brpat07 commented May 2, 2020

Fixes

Adding support and example for the feature of secure webhook

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 2, 2020
@brpat07 brpat07 added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels May 2, 2020
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #389 into master will increase coverage by 0.09%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   72.47%   72.57%   +0.09%     
==========================================
  Files           3        4       +1     
  Lines         476      485       +9     
==========================================
+ Hits          345      352       +7     
- Misses        127      128       +1     
- Partials        4        5       +1     
Impacted Files Coverage Δ
helpers/securewebhook/securewebhook.go 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49500d8...5ea8556. Read the comment docs.

@brpat07 brpat07 changed the title Add support and example for secure webhook feature Add support and example for secure webhook feature #minor May 3, 2020
@brpat07 brpat07 added status: code review request requesting a community code review or review from Twilio and removed status: work in progress Twilio or the community is in the process of implementing labels May 3, 2020
@anujs3
Copy link

anujs3 commented May 4, 2020

good work @brpat07! this LGTM, but should we add a unit test for getting the public key?

@brpat07
Copy link
Contributor Author

brpat07 commented May 4, 2020

good work @brpat07! this LGTM, but should we add a unit test for getting the public key?

I haven't added any code related to getting the public key, other then the example; so it does not make sense to add the unittest for that.

@eshanholtz eshanholtz changed the title Add support and example for secure webhook feature #minor feat: add support and example for secure webhook feature May 4, 2020
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshanholtz eshanholtz merged commit 9c30ae7 into master May 4, 2020
@eshanholtz eshanholtz deleted the eistats-1123 branch May 4, 2020 21:04
@brpat07 brpat07 restored the eistats-1123 branch May 6, 2020 05:59
@brpat07 brpat07 deleted the eistats-1123 branch May 6, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants