Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis builds #339

Merged
merged 10 commits into from
Jan 18, 2019
Merged

Fix Travis builds #339

merged 10 commits into from
Jan 18, 2019

Conversation

extemporalgenome
Copy link
Contributor

@extemporalgenome extemporalgenome commented Nov 1, 2018 •
edited
Loading

Travis builds for code PRs have been failing since Oct 2017.

Checklist

  • I confirm that the latest PR commit passes its Travis CI build.
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • N/A: I have added tests that prove my fix is effective or that my feature works
  • N/A: I have added necessary documentation about the functionality in the appropriate .md file
  • N/A: I have added in line documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2018
@SendGridDX
Copy link

SendGridDX commented Nov 1, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 1, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@bd7db2d). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #339   +/-   ##
=========================================
  Coverage          ?   71.88%           
=========================================
  Files             ?        3           
  Lines             ?      466           
  Branches          ?        0           
=========================================
  Hits              ?      335           
  Misses            ?      127           
  Partials          ?        4
Impacted Files Coverage Δ
helpers/inbound/inbound.go 11.27% <0%> (ø)
sendgrid.go 87.3% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7db2d...3df13eb. Read the comment docs.

@extemporalgenome extemporalgenome added the difficulty: medium fix is medium in difficulty label Nov 1, 2018
@thinkingserious thinkingserious merged commit 22672f7 into master Jan 18, 2019
@thinkingserious
Copy link
Contributor

Hello @extemporalgenome,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the fix-imports branch January 28, 2020 20:36
@childish-sambino childish-sambino mentioned this pull request Jul 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious Awaiting requested review from thinkingserious

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@extemporalgenome @SendGridDX @thinkingserious