Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update documentation for retrieving a list of all templates #295

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

renshuki
Copy link
Contributor

@renshuki renshuki commented Oct 7, 2018

Fixes #289

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update USAGE.md for retrieving a list of all templates (dynamic & legacy)
  • Update /example file for retrieving a list of all templates (dynamic & legacy)

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 7, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           3        3           
  Lines         451      451           
=======================================
  Hits          320      320           
  Misses        127      127           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34a53...2ccdec8. Read the comment docs.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels Oct 11, 2018
@ackleymi
Copy link

ackleymi commented Mar 1, 2019

Can this get merged? I lost time on this.

@renshuki
Copy link
Contributor Author

renshuki commented Apr 7, 2019

@thinkingserious do you think this could be merged?

@thinkingserious thinkingserious merged commit fd02ccd into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @renshuki,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Update documentation for retrieving a list of all templates (dynamic … docs: Update documentation for retrieving a list of all templates Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documenation for retrieving a list of all templates (dynamic & legacy)
6 participants