Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update examples using inline attachment with ContentID #282

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

anchepiece
Copy link
Contributor

Fixes #251

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This is a minor adjustment to attachment usage with SetContentID, hopefully making its use a bit clearer. The "Content-ID" header in a mail message is commonly used to reference the "Content-Disposition: inline;" embedded data within the HTML body. In many implementations the "Content-ID" header is omitted when the disposition is set to "attachment".

References

https://tools.ietf.org/html/rfc2183

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           3        3           
  Lines         451      451           
=======================================
  Hits          320      320           
  Misses        127      127           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b846cb...e2fdd4d. Read the comment docs.

@thinkingserious thinkingserious added hacktoberfest difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels Oct 5, 2018
@thinkingserious
Copy link
Contributor

Hello @anchepiece,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @anchepiece,

Thanks again for the PR!

You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:32
@childish-sambino childish-sambino changed the title Update examples using inline attachment with ContentID docs: Update examples using inline attachment with ContentID Oct 16, 2020
@childish-sambino childish-sambino force-pushed the docs/content-id-examples branch from e2fdd4d to dad8d14 Compare October 16, 2020 17:57
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino merged commit 4aa5f02 into sendgrid:main Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetContentID doesn't actually set content ID for attachments
4 participants