-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update examples using inline attachment with ContentID #282
docs: Update examples using inline attachment with ContentID #282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 70.95% 70.95%
=======================================
Files 3 3
Lines 451 451
=======================================
Hits 320 320
Misses 127 127
Partials 4 4 Continue to review full report at Codecov.
|
Hello @anchepiece, |
Hello @anchepiece, |
e2fdd4d
to
dad8d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #251
Checklist
Short description of what this PR does:
This is a minor adjustment to attachment usage with
SetContentID
, hopefully making its use a bit clearer. The "Content-ID" header in a mail message is commonly used to reference the "Content-Disposition: inline;" embedded data within the HTML body. In many implementations the "Content-ID" header is omitted when the disposition is set to "attachment".References
https://tools.ietf.org/html/rfc2183