Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and schedule a marketing campaign #233

Conversation

nafisfaysal
Copy link

@nafisfaysal nafisfaysal commented Oct 31, 2017

Checklist

  • Create a marketing campaign API
  • Create a marketing campaign Views

Todo

  • Create Scheduler for marketing campaign API
  • Create Scheduler for marketing campaign View

I will create another branch for the Scheduler you can merge this branch.

Short description of what this PR does:

Reference: #170

  • Create the marketing campaign API I follow MVC pattern( to get other developers grab it easily) .Then I create the update marketing campaign API.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@dmowcomber
Copy link
Contributor

This PR will be much easier to review once #197 is merged.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Mar 6, 2018
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@thinkingserious
Copy link
Contributor

Hello @nafisfaysal,

First, my apologies for the super delayed code review.

Secondly, if you are still interested in getting this merged, we would appreciate the following:

  • some tests
  • some documentation

Once we have these, we can dig deeper and provide a proper code review.

And THANK YOU!

With best regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap and removed difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio labels Oct 2, 2020
@nafisfaysal
Copy link
Author

Hello @nafisfaysal,

First, my apologies for the super delayed code review.

Secondly, if you are still interested in getting this merged, we would appreciate the following:

  • some tests
  • some documentation

Once we have these, we can dig deeper and provide a proper code review.

And THANK YOU!

With best regards,

Elmer

@thinkingserious Hey there, I hope that you are well during this pandemic.

I am really sorry, this time I can not move on with this issue. I very hope in the future, I will make more contribution to SendGrid open source 🙂

Thank you very much. You guys are doing fantastic stuff.

Have a great day.

Kind regards
Nafis

@childish-sambino childish-sambino removed the status: waiting for feedback waiting for feedback from the submitter label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants