Perform translations at runtime; add persistent settings #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
i18n-at-runtime
branch
2 times, most recently
from
07f61ab to
9d5dc6f
Compare
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.9.10-final-0 -----------
~ 147 passed in 16.76s ~ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #73
I took a slightly different approach to the problem than originally spec'd in the issue. Rather than bundle all translations with the firmware, which would bloat the firmware binary and potentially limit the number of locales we could support in the future, I opted to store all translations on the microSD card and, if not present, fall back to English as the default baked-in language.
Just as a note for future reference, the function that loads translations from SD (
translations) could trivially be updated to search in multiple locations if someone in the future did want to explore bundling compressed translations in the firmware.As part of this work, I also added back the ability for settings to persist (also via microSD) so users don't have to constantly be going into the settings menu just to change their default language.