Settings submenu #54
Merged
Settings submenu #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2021 04:40
- Adds 'Settings' item to the start menu - Adds 'Network' as editable setting (persists via network.txt setting) - Removes 'Network' from About - Adds 'Printer' with baudrate as editable setting (persists via printer.baudrate.txt setting) - Adds 'Debug' with log level as editable setting (that DOES NOT persist; more below) Previously, log level was set to ERROR by default and had to be overridden with a 'log.level.txt' settings file. After thinking about this more from a security / peace-of-mind standpoint: 1. Log level now defaults to NONE, 2. Log level can only be changed by the user updating it explicitly (every session) from within this new location in the UI, and 3. On startup and any time the log level is changed, the existing log file is removed.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.