Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add camera modes hint #516

Merged
merged 5 commits into from
Feb 26, 2025
Merged

add camera modes hint #516

merged 5 commits into from
Feb 26, 2025

Conversation

odudex
Copy link
Member

@odudex odudex commented Feb 25, 2025

What is this PR for?

Add camera mode toggle hint and refactor camera image rendering

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (b375d67) to head (87f88af).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #516   +/-   ##
========================================
  Coverage    94.94%   94.94%           
========================================
  Files           75       75           
  Lines         8388     8394    +6     
========================================
+ Hits          7964     7970    +6     
  Misses         424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadeubas
Copy link
Contributor

Awesome idea! Tested on Cube, Dock, Yahboom and Amigo here without any issues. Nice job! 👍

@jdlcdl
Copy link
Collaborator

jdlcdl commented Feb 26, 2025

Tried this on amigo and --unsupported yahboom_devkit, worked very well. Also worked well on simulator for amigo.

Not sure what to expect for other devices, but simulator for yahboom overlaid the camera image on-top of the mode hints, which was not the case on the yahboom_devkit (while I expect that yahboom and yahboom_devkit have similar screens).

These hints are great to uncover very useful features (zoom mode relieves me from having to refocus camera on my amigo often).

@odudex
Copy link
Member Author

odudex commented Feb 26, 2025

Simulator: Fixed simulator for Yahboom, Dock, also M5stickV which was not showing anything at all.
I also changed the color settings as camera feed was bluish on my PC, please let me know if colors got messed up for you.

@odudex odudex merged commit e5f3ebf into selfcustody:develop Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants