Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rare error when loading mnemonic word numbers #513

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

tadeubas
Copy link
Contributor

What is this PR for?

Fix errors when Loading Mnemonic > Via Manual Input > Word Numbers and input is empty and user click on "GO" btn:

  • ValueError: invalid literal for int() with base 10: ''
  • ValueError: invalid literal for int() with base 16: ''
  • ValueError: invalid literal for int() with base 8: ''

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (fc0e661) to head (3fd4001).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #513      +/-   ##
===========================================
+ Coverage    94.86%   94.91%   +0.04%     
===========================================
  Files           75       75              
  Lines         8361     8364       +3     
===========================================
+ Hits          7932     7939       +7     
+ Misses         429      425       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex odudex merged commit 3a0771a into selfcustody:develop Feb 24, 2025
7 checks passed
@odudex
Copy link
Member

odudex commented Feb 24, 2025

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants